Daniel Martí

Results 1447 comments of Daniel Martí
trafficstars

Reduced as https://github.com/cue-lang/cue/issues/3836 :) I will close this issue as resolved then, as the performance seems good now.

To follow up here, @massive - evalv3 as of cfbeb48088c9674480496969ad85a93602e9778c, having fixed https://github.com/cue-lang/cue/issues/3838, does make your project work faster and correctly now: ``` $ for n in 0 1; do...

@freeformz if you're unable to reduce the reproducer to be shared publicly, can you send it to me privately, for example via Slack? I can then do the reduction work...

Apologies for the slowness, @freeformz, I've been on holiday recently. @cuematthew and I have reduced the "unused import" error to this testscript: ``` exec cue trim input.cue -- input.cue --...

We found the cause :) In your config, you had a list comprehension that always resulted in zero elements (`./elevation/apps/config._satebatcherValues.app.components`, which also has conflicting list types between `[...string]` and `[...{}]`?),...

The `astutil.Sanitize` fix is now at https://review.gerrithub.io/c/cue-lang/cue/+/1198351. Please ignore my mention of a list type mismatch - we spent a while aggressively reducing your code to reach the dozen lines...

It's been two weeks since the comment above, and we released v0.13.0 last week, so I'm going to assume that the issue here is resolved, like most other `cue trim`...

Out of curiosity, how does wall time compare between v2 and v3?

@alecholmez would you be able to try again with the latest master, and post wall time and memory usage numbers? Also, is this with a public project or with a...

> This code is quite custom so would be more than happy to setup a meeting and walkthrough what's going on here. I would also be up for this if...