Mark Van Moer

Results 10 comments of Mark Van Moer

record_logger.hpp (and other *_logger.hpp files) are removed by PR #383 but your overall point still stands.

@qinjunj - in the comment that carries over from the previous PR "Also, please remove record_logger related code in [Kimera-VIO](https://github.com/ILLIXR/Kimera-VIO/tree/master) and [OpenVins](https://github.com/ILLIXR/open_vins/tree/master)." - ripgrep doesn't return anything for "record_logger" in...

Not counting the #include of the older cpu_timer.hpp, there are two issues in OpenVins. 1. ov_core/src/track/Grider_FAST.h has a commented out use of the PRINT_RECORD_FOR_THIS_BLOCK macro, which could either just be...

Assuming that I can just remove all the outdated metrics code from OpenVins, during building it crashes because it's trying to use imu_cam_type. The output message suggests replacing with imu_raw_type,...

I think it was that configs/clean.yaml still has version: 3.1 for OpenVins, setting that to 3.2 fixed the imu_cam_type problem

Current status - all of Qinjun's original suggestions have been implemented. Still fails ci.yaml because of an assert getting triggered in Kimera-VIO. The consensus reached during the Thursday meetings has...

@jianxiapyh - I made a PR a while back which addresses the above OpenVINs issues https://github.com/ILLIXR/open_vins/pull/21 changing configs/rt_slam_plugins.yaml to have OpenVINs use version commit 00bc801seems to suffice. I didn't know...

I am unable to replicate the configs/native-vk.yaml sytax error. For me, it runs vkdemo, but then hangs when the demo is finished for about a minute before runner crashes with...

> @jianxiapyh - I made a PR a while back which addresses the above OpenVINs issues [ILLIXR/open_vins#21](https://github.com/ILLIXR/open_vins/pull/21) > > changing configs/rt_slam_plugins.yaml to have OpenVINs use version commit 00bc801seems to suffice....

@jianxiapyh - I believe just estimate based on the SQLite number at this time. If I ever get the ILLIXR/ILLIXR-analysis repo sorted out, that would at least provide charts to...