Ivan Mushketyk
Ivan Mushketyk
I've removed `deprecated: true` from the "magic-to-const" rule that accidentally was added there.
> Ensure send return value is checked I was thinking about implementing this rule, and it seems that to avoid false positives we should keep track of all variables of...
Build if failing because it requires an updated version of `sol-explore`. The fix is here: duaraghav8/sol-explore#3 Explanation is here: https://github.com/duaraghav8/Solium/issues/178
Hey, @duaraghav8 This seems like a useful PR. Do you want to merge it into the repo?
@duaraghav8 I have stupid question. How can we execute rules in parallel if NodeJS is single-threaded? Start parallel processes?
I've implemented the `getNthParent` method, but it won't work with the current implementation of the `sol-explore`. If I understand it correctly the problem is that `sol-explore` incorrectly identifies parent references....
Isn't this a duplicate of the first item in this issue: https://github.com/duaraghav8/Solium/issues/178 ?
I can implement this. Should the command with the `--rule` flat look like this: ``` ./bin/solium.js --rule 'quotes: ["error", "double"]' --rule 'indentation": ["error", 4]' ```
Do I understand it correctly that after this change this code in the `RawTransactionManager`: ```java if (chainId > ChainId.NONE) { ... } ``` will be replaced with something like: ```java...
@MichaelDrogalis I was referring to this section: https://github.com/onyx-platform/onyx-starter/blob/0.8.x/WALKTHROUGH.md#state-management