murshex
murshex
@JordiFB @JarWarren @SergioGuerreroFB @owaisfb @zpao @jawwad
I think this should still be Edit: https://github.com/manigandham/serilog-sinks-fastconsole This seems related
https://github.com/c0nd3v/Serilog.Sinks.Channels I made my implementation of channels for serilog publicly available. Hope this helps someone!
@nblumhardt No problem :) Is there anyway we could put this into official Serilog github?
I think it’s important to guarantee uniqueness because this is just a potential source of problems
In TcpServer.cs, RegisterSession uses Sessions.TryAdd but doesn’t handle a false return value (Aka duplicate guid)
I’ve seen that stackoverflow post before, but I don’t see any hard evidence. After researching: From dotnet runtime: https://github.com/dotnet/runtime/blob/main/src/libraries/System.Private.CoreLib/src/System/Guid.Windows.cs Function being used: https://docs.microsoft.com/en-us/windows/win32/api/combaseapi/nf-combaseapi-cocreateguid *To a very high degree of certainty,...
https://stackoverflow.com/questions/2621563/how-random-is-system-guid-newguid-take-two After reading this I feel less confident…
Instead of using a Guid identifier, what about using Interlocked.Increment ?