Tony Murray

Results 522 comments of Tony Murray

I couple of thoughts: try to match any upstream env vars as much as possible try to avoid much code in config files.

Additional, there seems to be some docs here: https://docs.librenms.org/Extensions/Redis-Sentinel/

I reviewed this a bit, but this doesn't seem to align: https://github.com/predis/predis?tab=readme-ov-file#client-configuration

Sure, but it seems to want settings about replication and/or cluster and/or service.

@dot-mike is it? I don't think it sets those options does it? I just want to make sure it is fully functioning and thought out. It is harder to fix...

I think no thanks for now.

Perhaps we need to have a discussion about what level we want to target? The higher the level the higher the burden on the contributors. The reason I'm reluctant is...