Tony Murray

I would love someone to step up to do releases for the Docker image. I don't really have the capability to test them etc. It would need to be someone...

@PipoCanaja might need to add the ability to save json for the module. For legacy modules, that is set here: https://github.com/librenms/librenms/blob/master/tests/module_tables.yaml

@electrocret usually, in yaml, IF-MIB::ifName is fetched and used to replace.

This module was one that I have considered making it more generic. To allow vendor MIBs and additional datas like: r/w latency, queue depth, utilization, and r/w errors.

honestly, I think I prefer links as it is a bit more descriptive. It is annoying to have to migrate configs. I'm ok with either way.

> > Where do you see that one ? Don't have it here. > > since @murrant enabled error reporting in #17672 ... workflow/test window is full of garbage :)...

find_device_id and find_port_id will need to be moved at some point. (also, they are kind of a mess) Maybe it would be better to rewrite those at a future time.

I don't think PortCache is the correct place for that code.

I initially said they shouldn't be moved in the PR. Sorry, I was kind of making a mental note. I didn't mean to have you move the code around. If...

maybe don't define the array in raw json. Define it as an array.