Tony Murray

Results 457 comments of Tony Murray
trafficstars

Oh, I see what you mean. I really was not understanding what you said :) The trait won't work in that section of code. It can only be on a...

Hmm, you've disabled the rrd updates in your poller debug, which I kind of need to see. Either try again with rrd enabled, or `./scripts/collect-snmp-data.php -h -m slas`

@djdarak it appears as though your device is not returning the data for those other graphs. rttMonLatestJitterOperMOS rttMonLatestJitterOperICPIF rttMonLatestJitterOperOWAvgSD rttMonLatestJitterOperOWAvgDS rttMonLatestJitterOperAvgSDJ rttMonLatestJitterOperAvgDSJ

Odd, I don't see the jitter graphed there... but I don't know much about the slas code.

As far as I understand this script, it should just return an integer right? I'd suggest just casting it to an integer here: https://github.com/librenms/librenms/blob/0bbcde12279491efc75c9b8c2ff3203ee4749903/includes/polling/applications/os-updates.inc.php#L15 `$fields = ['packages' => (int) $osupdates];...

Yeah, might be better to send a null when there is an error. `$fields = ['packages' => is_numeric($osupdates) ? (int) $osupdates : null];`

data_update will skip the update for influxdb I believe. for rrd, it writes NaN

If you look at https://github.com/librenms/librenms/blob/master/includes/polling/applications/mysql.inc.php#L118 the max is set there... probably a fix would include setting that to a larger number or unlimited. That would only fix new rrd files....

Not 100% sure of the use case here, wouldn't adding `./discover.php -h all -m fdb-tables` to the cron work?

Depending on how frequently you schedule the fdb discovery, it could end up with multiple running at the same time and should result in all being completed within that frequency...