woonki

Results 237 comments of woonki

> I guess this is what has been described as a limitation in [#6664 (comment)](https://github.com/rescript-lang/rescript-compiler/pull/6664#issuecomment-1976247679) Thanks for refreshing my memory. You're right, it's something we didn't implement due to the...

Thank you for reporting the issue. Can you inform me of what version of ppx_spice you are using?

> This error was produced with v0.2.3. I've downgraded to v0.2.2, which works fine. > > I tried altering `Spice.res` to add some opens: `open Belt` worked for the `Float`...

I've added this section for the compiler compatibility guide before. I'll revise this more accurately. https://github.com/green-labs/ppx_spice#compatibility-on-the-compiler-versions

> I'm having the same issue with v11, downgrading to v0.2.2 solves it. > > Is there any progress on this issue? There is no functional difference between v0.2.3 and...

This may not be related to this PR, but the genType output for v12 still differs from v11 in this way. ```res // Title.res @genType @react.component let make = (~text)...

https://github.com/rescript-lang/rescript-compiler/issues/7106

I'm thinking that adding primitives to have the compiler throw errors when using max or min with bigint might be a good idea. What do you think?

> Actually the compiler's `%min` / `%max` primitives already support bigints as well, and I don't think there's reason to drop it. As far as I know, JavaScript does not...

I guess there is an issue with latest master branch: ```rescript let max0 = max(1n, 2n) let min0 = min(1n, 2n) let c0 = 1n > 2n let a =...