woonki
woonki
This seems be working based on the textual match in AST. In case of newly value binding would not work. e.g. `let ue = React.useEffect`. And it is a little...
Previous discussion for reference: https://github.com/rescript-lang/rescript-react/pull/97
Downside of manipulating the expression directly based on the textual match. Instead, we can use the attribute such as `@deps` that is more recommneded way for ppx. ```res useEffect(_ =>...
@cknitt Thanks! I'll keep going through the test cases and see if I can reduce the breaking changes.
Yes, that is one of things to be fixed in this PR. The trasformation of component definition is changed in this PR as below: ```res // before type props switch...
> You you can't do type inference under an application. But, you could do this: > > ```rescript > let make = { > let \"Abstract" = (props: props) =>...
If I change the application location of the `React.component` as advised, I still get a build error. But if I add code that uses the component, the build succeeds regardless...
@cknitt Off the top of my head, if we were to make the type of the react component abstract, so that we could use the React.component identity function via ppx...
Rebased to master
> @mununki I tried to build one of our projects (fairly large, web + React Native) with this change. > > And actually this didn't look too bad. All dependencies...