James Munnelly
James Munnelly
Could you split this into two commits, one with actual changes to code and the other with the `go fmt` changes? 😄
I'd also like to discuss the API surface for this - I think something more like `cleanupPolicy: [Delete|Never]` may feel more natural and be more informative to our users :)...
This isn't something we're planning on changing imminently, but it does make sense to make it easier to have this sort of behaviour configured. I think to do so, we'll...
For what it's worth, it's considered a misconfiguration to have two ingress resources both referencing the same Secret name and *both* with cert-manager annotations. My first bit of advice here...
@jakobhostnik can you open an issue on the cert-manager-csi repo for this request? (cc @JoshVanL) This issue is going to take a bit of work to resolve I think. It's...
I think I understand _why_ this is happening, and I also don't think this is a good first issue for new contributors 😅 When both Order objects are created, because...
I'd _really_ like to see an e2e or integration test for this however, that can reliably test this case out and fail (prior to us adding a patch to resolve...
Can you share your full pod definition for the cert-manager-controller? Are you using `hostNetwork: true` by any chance?
The `dns01` related flags are not used at all for Vault, as DNS01 relates to *ACME* typed issuers - the regular DNS resolution stack is used to resolve the name...