munger1985
munger1985
if changed to check the label value from nodeclaim, will have no impact to the existing projects.
just one line change
if we use the common label to select the nodes which needs to be removed, as it is the common label wellknown label for k8s, some cloud provider like oci...
without this, downstream (karpenter-oci)has no way to fix the bugs when oci has flex shape, karpenter will keep disrupting the nodes and create the same flex shape with the same...
https://github.com/kubernetes-sigs/karpenter/pull/2402 I suggest we dont use the common label node.kubernetes.io/instance-type in node, we can use this label in nodeclaim, i have tested it, it worked. pls check my fix in...
becuz the common label will be enforced by OCI CCM, which can not be easily customized, but we can customize it the label in nodeclaim, as nodeclaim is only enforced...
and the beauty of my fix is it does no harm to existing app, as currently this label(node.kubernetes.io/instance-type)'s value in nodeclaim is the same as the label's in node, the...