Martin Ukrop

Results 38 comments of Martin Ukrop

Sorry it took so long, my past two weeks were also rather busy.

I do apologize for my inactivity, but I'm rather busy now. I'd be glad if you managed to resolve this without me.

Hi. I've looked into this after a longer while. In the end, I used the [Addressable class](https://www.rubydoc.info/gems/addressable/Addressable/URI) for URI parsing as 1. URI is not capable to process non-ascii characters...

I'm off for the rest of the week but I believe I'll be able to find some time for this next week :-).

Hi. I've tested the patch, but the issue is not fixed, the error seems the same. ``` /usr/lib/ruby/2.7.0/uri/rfc3986_parser.rb:21:in `split': URI must be ascii only (URI::InvalidURIError) ```

Aah, sorry @jochenjonc, I misunderstood what I was supposed to check. I did it properly now and, indeed, #61 fixes the thing! For testing purposes, I've added an extra commit...

Oh, and you are not the repository owner either, I thought you were :-).

> If we just want to check whether some library behavior changed, there may be easier ways (e.g. seeing how the mapping file compares to the previous one). I see....

Done for six cases, review needed.