Kenta Mukai

Results 11 comments of Kenta Mukai

same here. (v1.6.4) https://github.com/chaps-io/public_activity/blob/1-6-stable/test/migrations/001_create_activities.rb ``` ../../lib/generators/public_activity/migration/templates/migration.rb ``` Is this symbolic link file broken? In my local environment: ``` $ readlink /usr/local/rbenv/versions/2.6.2/lib/ruby/gems/2.6.0/gems/public_activity-1.6.4/test/migrations/001_create_activities.rb test/migrations/../../lib/generators/public_activity/migration/templates/migration.rb $ cat /usr/local/rbenv/versions/2.6.2/lib/ruby/gems/2.6.0/gems/public_activity-1.6.4/test/migrations/001_create_activities.rb cat: /usr/local/rbenv/versions/2.6.2/lib/ruby/gems/2.6.0/gems/public_activity-1.6.4/test/migrations/001_create_activities.rb: No such file...

Oops, you were already using `previous_time` and trying to take some further care of it. I will wait for your PR. You can refer to my test code if you...

@marcelolx Sorry, I did not understand how busy you were. Let me explain about my motivation. To completely prevent the sidekiq scheduler from running multiple cron jobs, the server must...

https://github.com/sidekiq-scheduler/sidekiq-scheduler/pull/463 This code is better. thanks!

@afrase @marcelolx You've done a great job. Thanks! When the new version of the gem is released, we will use it in our products.

I was assuming intervals like once a day, but this PR seems to take into account shorter intervals like 1 minute intervals. Very nice.

@marcelolx Thanks for the 5.0.4 release. We updated it immediately. It is working fine, but I have not yet been able to generate an event that delays job execution by...

@ericproulx Thanks for pointing out that PR! I believe the root cause is the shallow copy issue, so I don't think kwargs alone would solve it: https://github.com/ruby-grape/grape/blob/07fcf03e8c096e8f8016c8fc372c7f904e478e79/lib/grape/endpoint.rb#L172-L175 However, I'll test...

@ericproulx Thank you for taking the time to look into this issue! **Use cases for modifying `options` in our codebase:** ### 1. `options[:include]` We use this to pass the client-requested...

Looking at the two examples I provided, both use cases were for communicating with [ActiveModelSerializers](https://github.com/rails-api/active_model_serializers) through `options`. If we can achieve the same thing using `env`, that would work for...