Matt Wise

Results 9 comments of Matt Wise

HI @benjdlambert, I've looked further into this issue and the problem appears to be with the use of `basename` in the `dir()` function in `@backstage/backend-common`. after loading the tree from...

@benjdlambert If I get time in the next week, I will look into doing this. I haven't built any of the libs before locally, so I will need to make...

Fixed in https://github.com/backstage/backstage/pull/22884 @benjdlambert Please let me know next steps

> Hi! Thanks. We use changesets for release management and versioning, so do make one along with your PR (`yarn changeset`) and revert the modifications to the changelog and package.json....

@freben I have reverted previous commits to changelog/package.json and replaced with a single changeset commit as requested

> Thanks for this! 🎉 > > I'm gonna merge this in to get it into the `next` release that's going out this afternoon, but would really appreciate it if...

I've reverted the changeset commit per the tooling's request

@benjdlambert following up on this since this test update is related to the fix from https://github.com/backstage/backstage/pull/22884 that is going out tomorrow.

> I'll check that with moto. Maybe > > ``` > @pytest.fixture > @mock_aws > def mocked_ses(): ... > ``` > > will work. This fixed it for me, thanks!