Michał Trojnara

Results 96 comments of Michał Trojnara

I don't think our code uses Thread-local storage (TLS) directly, but some libraries may use it. Have you tried using a different compiler (e.g., clang instead of gcc or gcc...

Opening one issue for several features makes tracking their implementation hard. Which new PKCS#11 3.0 features were actually implemented in OpenSC? Which of them do you consider useful for libp11?

> add definitions for new PKCS#11 3.0 API, try to use it (and fallback to 2.x API if not available) Does support for new key types depend on it?

https://en.wikipedia.org/wiki/KISS_principle

> These functions are being deprecated in OpenSSL 3.0 @dengert What does OpenSSL 3.0 have to do with PKCS#11 3.0 (besides the version number)?

See the related https://github.com/OpenSC/libp11/pull/378#issuecomment-755602309 for a way to implement this functionality without changing the public API. We really should avoid adding new functions for each key type and use the...

> > > > See the related [#378 (comment)](https://github.com/OpenSC/libp11/pull/378#issuecomment-755602309) for a way to implement this functionality without changing the public API. We really should avoid adding new functions for each...

@dengert Which method do you recommend for supplying additional parameters?

@dengert Good point. My question was too generic. Let's focus on the task at hand. Should we merge this PR as it is, or should we look for an alternative...

@dengert I prefer adding something like `PKCS11_generate_key_ex()` with a flexible set of parameters over a separate API function for each key type. I also agree that we need a parameter...