Miloslav Trmač

DO NOT MERGE: Testing https://github.com/containers/image/pull/2487

2

#### Does this PR introduce a user-facing change? ```release-note Do not merge this ```

DO NOT MERGE: Run tests with Zstd:chunked compression default

3

Inspired by https://github.com/containers/podman/pull/20633 ; now that #21571 is succeeding, let’s see what happens in the more complex case. #### Does this PR introduce a user-facing change? ```release-note do not merge...

chunked layersCache seems to never be actually reused

1

A side discovery I can’t delve into now: https://github.com/containers/storage/blob/98ad80d6d16593c959d77b03b33af555eb620891/pkg/chunked/cache_linux.go#L114 defines a new local variable, it does not change the value of the global singleton: https://github.com/containers/storage/blob/98ad80d6d16593c959d77b03b33af555eb620891/pkg/chunked/cache_linux.go#L77 AFAICS that means every cache...

c/image calls `chunked.GetDiffer` immediately followed by `store.ApplyDiffWithDiffer` ~ `differ.ApplyDiff`. Currently `convert_images` happens in the latter call; but that means it happens with the layer store locked for writing. It seems...

Delete the Windows storage driver?

6

Ever since 1eba391bd3cde8005087b661a2f07e803ecba390 in Sep 2017 the driver’s test can’t compile because a `addAceToSddlDacl` function is missing. Clearly no-one is even trying to make it functional. Can we remove that...

Keep golangci-lint up-to-date

1

AFAICS the version is being maintained in https://github.com/containers/storage/blob/11c84264afec764e97f3b483a7781f5d0fe0bfda/tests/tools/Makefile#L32 , and only updated manually. Many of our other projects have version updates automatically filed via Renovate, it would be nice for...

WIP: oci/layout API extensions

1

Includes @sourceIndex code from https://github.com/containers/image/pull/1677 . Do not merge: - At least the transport part must have tests (probably mostly from 1677). - Do we want to add this to...

Propagate `CompressedDigest`/`CompressedSize` when reusing data from another layer

2

We record (some) `CompressedDigest`/`CompressedSize` when pulling a layer from registry; but, previously, we would lose these values (and record uncompressed values) when creating a duplicate of a layer already present...

Encrypted images don’t benefit from zstd:chunked , and if asked to do so, the code uses non-chunked zstd (ref. https://github.com/containers/image/issues/2485 .) Around https://github.com/containers/common/blob/1a8d1919e2cea08126f8e26c33562ffe2933086c/pkg/config/containers.conf#L442 , and for `add_compression` option: the documentation...

Fix `d.getStagingDir("")`

1

Since #1784 , https://github.com/containers/storage/blob/10981abafe3e3ece4e0cc872761f7624cd1bef0e/drivers/overlay/overlay.go#L2188 is calling `getStagingDir("")`, i.e. `dir2` with a layer ID `""`. Just from reading the code, that _happens_ to work as expected because it is not using...