Miloslav Trmač
Miloslav Trmač
Currently, signature verification can fail with https://github.com/containers/image/blob/e3293eaa4a81a99f33d1fda1eb9495aec722043f/signature/policy_eval_signedby.go#L118 . That’s technically correct; overall the codebase could be more helpful if signatures can’t possibly be read: - because the input transport does...
Currently identity mismatches fail just with https://github.com/containers/image/blob/e3293eaa4a81a99f33d1fda1eb9495aec722043f/signature/policy_eval_signedby.go#L66 which contains the identity from the signature, but does not say what _would_ be accepted. That information can be found in the policy,...
We _typically_ don’t actually use the data (`storageImageDestination.Commit` skips `blob.EmptyLayer`), and `GetBlob` already special-cases that blob to return it from memory. So, `TryReusingBlob` should always declare that the layer is...
Trying to see what a fix for the Packit-reported failures (as in https://github.com/containers/skopeo/pull/2297#issuecomment-2059524991 ) would look like. @lsm5 does this build on all distributions we care about for the `main`...
Captured from PRs * [ ] Integration tests for https://github.com/containers/image/pull/1595 * [ ] Integration tests for https://github.com/containers/image/pull/1597 * [ ] Integration tests for https://github.com/containers/image/issues/1598 * [ ] Integration tests for...
Skopeo (and c/image it wraps) is currently configured as a traditional UNIX application — with various files in `/etc` and the users’ home directory. This makes it operationally difficult to...
A minimal prototype for a fix of #1888 . Note that this would immediately break pulling all currently-existing layers. Also this probably increases memory requirements because the TOC exists as...
@giuseppe Zstd:chunked has uses a `TarSplitChecksumKey` annotation, separate from the TOC digest. That’s fine as far as per-image individual trust goes, because the annotation is authenticated by the manifest digest....
I’m trying to fix storage tests in c/image after 3 years they basically didn’t work at all (https://github.com/containers/image/issues/1729 ), and I’m running into a race condition that reproduces 100% for...
https://github.com/containers/storage/pull/1522 has disabled 5 out of the 7 default golangci-lint linters. That seems excessive. For the record, currently: ```console % golangci-lint version golangci-lint has version 1.52.2 built with go1.20.2 from...