Mike Tougeron
Mike Tougeron
@nojnhuh / @jackfrancis I'm not sure what the apidiff job is telling me is wrong. I know it's tell me _something_ is wrong but I don't know how to track...
> @mtougeron we don't have a lot of E2E coverage around BYO VNET for AzureManagedCluster scenarios, are you confident in your own manual tests that this is feature complete and...
@jackfrancis I tested this again for BYO VNET and it doesn't make any changes (as expected/desired). However, as I look closer, there isn't any validation done on the `AzureManagedControlPlane.spec.virtualNetwork` (and...
Apparently I created a regression with my last round of fixes since the `pull-cluster-api-provider-azure-e2e` test keeps failing. I'll figure out what's different in my manual testing vs the automated test...
/test pull-cluster-api-provider-azure-e2e
Ah, finally tracked down the failing log message. ``` E0930 16:32:16.616238 1 controller.go:326] "msg"="Reconciler error" "error"="admission webhook \"validation.azurecluster.infrastructure.cluster.x-k8s.io\" denied the request: AzureCluster.infrastructure.cluster.x-k8s.io \"capz-e2e-i7wx2l-public-custom-vnet\" is invalid: [spec.networkSpec.subnets[0].CIDRBlocks: Invalid value: []string{\"10.0.0.0/24\"}: field...
/test pull-cluster-api-provider-azure-e2e
Not sure what's up with prow but I'm going to try again. /test pull-cluster-api-provider-azure-e2e