Mike Tougeron
Mike Tougeron
@jtblin Any chance you can review this PR? This is causing problems for us in our multi-tenant environments. Thanks!
Any chance this PR can be reviewed/approved?
/assign @jantzenallphin
> @mtougeron quick question about the stated scope in the issue description: > > Is the reason why this is not appropriate for BYO VNET because in those scenarios the...
As a user I would love this functionality. Not being able to test preview features is a limitation that I'm bumping up against (e.g., BYO CNI). Two high-level thoughts that...
Current outstanding TODOs: - [x] Write new docs on how to use this features along with limitations - [x] Refactor the subnet reconcile function so it can update existing subnets...
When running the tests with the api version conversion changes I'm getting the following error and I'm not sure how to address it. If someone could help point me in...
Per the [slack conversation](https://kubernetes.slack.com/archives/CEX9HENG7/p1662487418501269), the sticking point I'm currently running into is this `make generate` error. Otherwise things seem to be working. ``` /Users/tougeron/src/go/src/github.com/mtougeron/cluster-api-provider-azure/hack/tools/bin/conversion-gen-v0.23.1 \ --input-dirs=./exp/api/v1alpha3 \ --output-file-base=zz_generated.conversion \ --go-header-file=./hack/boilerplate/boilerplate.generatego.txt...
The more detailed apidiff is ``` sigs.k8s.io/cluster-api-provider-azure/api/v1beta1 Compatible changes: - ServiceEndpointSpec: added - ServiceEndpoints: added - SubnetSpec.ServiceEndpoints: added sigs.k8s.io/cluster-api-provider-azure/azure/services/subnets Compatible changes: - SubnetSpec.ServiceEndpoints: added sigs.k8s.io/cluster-api-provider-azure/exp/api/v1beta1 Incompatible changes: - ManagedControlPlaneSubnet: old...