Matt Todd

Results 23 comments of Matt Todd

Build failing due to #166, but is green otherwise, which tells me we probably need better tests for these code paths.

Reading material (some modern, recent, relevant, and others not quite so fresh): - http://spin.atomicobject.com/2013/09/30/socket-connection-timeout-ruby/ - http://mikeperham.com/2009/03/15/socket-timeouts-in-ruby/ - http://stackoverflow.com/questions/9853516/set-socket-timeout-in-ruby-via-so-rcvtimeo-socket-option/12111120#12111120 - http://stackoverflow.com/questions/9853516/set-socket-timeout-in-ruby-via-so-rcvtimeo-socket-option

Generally, I prefer to require essential dependencies and leave non-essential utilities as optional. In this case, Net::LDAP::DN is not essential to the normal function of Net::LDAP operations, searching, modifying, etc,...

@jch I can handle this, no problem. I'm :-1: on RDoc formatting and would prefer Markdown moving forward (aiming to replace existing RDocs along the way). Sound reasonable, @jch @schaary?

@schaary think it's worth throwing a test together to reproduce this?

From the spec, as @jzinn [points out](https://github.com/ruby-ldap/ruby-net-ldap/issues/43#issuecomment-12749266): > Clients SHOULD be implemented to require > user selection of the Unauthenticated Authentication Mechanism by > means other than user input of...

Looks hardcoded here: https://github.com/ruby-ldap/ruby-net-ldap/blob/78c159b3ea747b4316334c2032445585b2bfe7c6/lib/net/ldap.rb#L1183 If this were configurable, it would likely mean disabling specific features (like search result paging/sorting, SASL auth, etc). If setting the constant is working for you...

@renier just curious, what LDAP server are you connecting to that forces you to use version 2?

https://github.com/ruby-ldap/ruby-net-ldap/pull/172 is an example of some fairly significant issues with our implementation of BER encoding: basic integer encoding is broken according to the spec.

Some relevant publications: http://www.oss.com/asn1/resources/books-whitepapers-pubs/asn1-books.html