Mihai Claudiu Toader

Results 39 comments of Mihai Claudiu Toader

Trying this with latest versions but i get this: ```ERROR: error loading package '@@com_google_googleapis~//google/rpc': Unable to find package for @@[unknown repo 'com_google_googleapis_imports' requested from @@com_google_googleapis~]//:imports.bzl: The repository '@@[unknown repo 'com_google_googleapis_imports'...

> Hey @mtoader thanks for the PR. > > I understand it does create friction to have two different import aliases within the same package for the same import, but...

Also .. please advice on how to write those tests better. Right now they fail with this: ``` go: downloading golang.org/x/tools v0.2.0 go: downloading golang.org/x/mod v0.11.0 go: downloading github.com/yuin/goldmark v1.4.13...

> @mtoader, would you be able to provide a repro example and an error message for the situation? let me try

> > @mtoader, would you be able to provide a repro example and an error message for the situation? > > let me try @r-hang see https://github.com/mtoader/sample-gomock. Checkout and do...

> > > @mtoader, would you be able to provide a repro example and an error message for the situation? > > > > > > let me try >...

> Sorry for the delay and thank you for the repro. I'm starting to take a look now, i'll have an update by Monday. Perfect, hopefully you can get the...

Yea .. my patch just attempts to manage the badness, the real solution is more complicated.

> Yea .. my patch just attempts to manage the badness, the real solution is more complicated. Thinking about what would be a good default behavior here, i think the...