Mike McCrea

Results 269 comments of Mike McCrea

As indicated by this line in the warning: `Method *new has 6 args, but doc has 5 argument:: tags.` The doc is missing one of the 6 method arguments, so...

@JordanHendersonMusic Seeing the squashed diff from that first LFUGens init sample fix PR made it more clear what you were seeing wrt adding `const` to changed code... So, because this...

I added tests for the UGens to which there are functional changes, `VarSaw` and `T2A`, anticipating the request ;) So this is ready for review!

How about something like: _Returns the running envelope of the signal, smoothed according to the attack and release times._ Then with a simple example included: ```supercollider ( { var att...

> Returns the running envelope of the signal, smoothed according to the attack and release times. The algorithm that is [used](https://github.com/supercollider/supercollider/blob/7bf46ead06c8c62b5c1ee17963e36e7c228fda63/server/plugins/FilterUGens.cpp#L3514) is an [envelope follower](https://www.cs.princeton.edu/courses/archive/spr05/cos579/DSP/DSP.html), so I think it's an...

At the risk of delaying the PR, I'd say we just go for the current clarifying change (with the addition of `related::` links), and anyone is welcome to elaborate more...

Feel free also to include the example I mentioned (or any other that's useful), as I think the plot clarifies much more than a mini exposition would. The confusion of...

@jamshark70 its not clear whether you intended to update the PR based on the discussion, or whether you'd like to keep it as is.

I see I may have confused the thread with this: > I'd say we just go for the current clarifying change (with the addition of related:: links), and anyone is...