Mike McCrea

Update: this PR has been updated with clang-format.

Thanks @jamshark70 and @muellmusik for having a look at this. It's been a very long time since I wrote this and I remember it being quite involved and a lot...

Thanks @jamshark70 for keeping an eye on this. > It also makes sense that inputs expecting a trigger should initialize their unit->m_trig to 0. I strongly agree! > So we...

Back at it again, and hopefully this time for the win :) I've reviewed all comments and updated the OP with clarifications and updates. ^^^ Inline reviews are addressed above...

Just a ping on this that this PR is ready for final review ☝️

Thanks @joshpar ! Given that this fix could affect the initial state of a number of UGen configurations, we could say something like: " Impulse is now initialized correctly such...

> @mtmccrea - I think adding it to the changelog wiki is good idea. thanks! Done! Thanks, @joshpar!

Hmmm.. Looks like a test isn't passing: https://travis-ci.org/supercollider/supercollider/jobs/564793041#L4506 > [!] TestPlotter:test_suppliedBounds (0.0s) (Did not complete.) ! Error: "ERROR: Message 'use' not understood." But I don't see `test_suppliedBounds` in [`TestPlotter.sc`](https://github.com/supercollider/supercollider/blob/develop/testsuite/classlibrary/TestPlotter.sc). Where...

Still troubleshooting what's breaking in the test (It's not breaking when I run it on my machine...) I'll post back here when it's ready for review.

Hi @dyfer and @brianlheim, finally finding some time to come back around to SC work during the holiday break... So I think this may be breaking on account of a...