Michael Lynch

Results 269 comments of Michael Lynch

@ligfx - Thanks! I've integrated your suggestions into #215. I'm going to close this PR, as I've learned more about CAOS since creating this PR, and I think I can...

Preface: Thanks for this tool! It's great! I'm seeing this as well on an old Raspberry Pi image: https://downloads.raspberrypi.org/raspios_oldstable_lite_armhf/images/raspios_oldstable_lite_armhf-2023-05-03/2023-05-03-raspios-buster-armhf-lite.img.xz If I burn the `.img.xz` version, caligula's verification fails. If I...

>Fusion currently gets its password directly from the PASSWORD environment variable, which is inconvenient when running it under a hardened systemd service (which expects programs to use paths to passwords...

This is mainly a proof of concept. The current test exercises fairly trivial logic, but if the maintainers are open to unit testing as a strategy, we can get more...

> The reason BRS is "easy" to incorporate is because it is an **interpreter** and because of this theres a ton of stuff you can't actually test with BRS. You...

@1hitsong - How many tests would we need to implement for this to be considered for merging? One useful place for testing would be [`parseVTT`](https://github.com/jellyfin/jellyfin-roku/blob/cd86ef6af7ec0dc2b61c5291cd27d3659e776db2/components/captionTask.bs#L269-L326). I noticed that it has...

>Running the test script, I don't see if running any tests. I get a long list of warnings and it tells me there were 0 passing tests. Can you share...

I'm seeing this as well. On my Roku Streaming Stick Plus and my Roku Premiere 4K, even when I disable subtitles on the Roku, it still shows subtitles and transcodes...

>Can someone test the code/build in https://github.com/jellyfin/jellyfin-roku/pull/546 and see if it resolved the issue. I tested it and the issue persists. I bisected the issue down to 91f7240261003d676870579edc4fddd2a8e7a2d1 so that's...

>Please test the updated code/build in https://github.com/jellyfin/jellyfin-roku/pull/546 and see if it resolved the issue. I tested it, and the issue unfortunately is still present even with 6744235dd6fcabeb4e7a5a1609ceb72734e75fc6.