mtd91429

I changed this to a draft. To assess the impacet, the following code was run off the current main branch (not the current pull request) and on my 12 year...

Because of the performance issues, it may not be desirable to add `_sweep_indirect_methods` to the `clone_document_from_reader` method. Rather, I'll probably generate helper methods similar to the `append_pages_from_reader` method which addresses...

Yes, the problem in this file is the xref objects. The way PyPDF2 reads pdfs is it essentially searches for the xref table and parses it. It then uses additional...

The current behavior is a bit more complicated. While looking at some of the cases of malformed destinations "out in the wild" which we use for testing, outline items with...

The bug is bigger than just the outline items. It seems to also involve named destinations as well. To reproduce the error, use the following code: ```python from PyPDF2 import...

I think it is an issue that PyPDF2 has had for a very long time. None of the outline code changes I made actually touched the get_outline_root() method because this...

In further digging, I think this really has to do with the method `clone_document_from_reader()`. The method first clones the document Root (which, contains the catalog references to Named Destinations and...

That seemed to work. With this fix, the `_sweep_indirect_references()` method gets called twice when generating a PDF by cloning it from the `PdfReader`: first when cloned, second when it is...