Mahé
Mahé
``` ./tools/controller-gen crd paths=./apis/... output:dir=apis/cilium.io/client/crds/v1alpha1 panic: interface conversion: types.Type is *types.Alias, not *types.Named ``` It looks like we are blocked by `controller-gen` that will be updated when we upgrade k8s...
Currently blocked on resolving https://github.com/kubernetes-sigs/controller-tools/issues/1053.
> Based on the discussion in https://github.com/golang/protobuf/issues/1609, it seems that the error might be coming from changes in the object sent in the gRPC. I believe we had issues with...
> We have the following failures in golangci-lint: > > > Running [/home/runner/golangci-lint-1.57.2-linux-amd64/golangci-lint run --out-format=github-actions --config=.golangci.yml --verbose] in [] ... > > cmd/tetra/common/client.go:62:15 staticcheck SA1019: grpc.DialContext is deprecated: use NewClient...
Aside I'll be off for the next two weeks, so feel free to ping someone else if you want to merge this earlier
> Can you remove this and I will create new PR? > @mtardy Hey, what would you like to remove? This PR seems to be closed already.
> > > Can you remove this and I will create new PR? > > > @mtardy > > > > > > Hey, what would you like to remove?...
> To be honest, I felt quite disheartened and lost some focus after seeing the assumption that I might have used an LLM to patch my code. I understand that...
This has been fixed by https://github.com/cilium/tetragon/pull/3864. Again I'm sorry I didn't want to demotivate you and hope you'll continue contributing to Tetragon, I'll be happy to review other patches :)!
> Just tried out locally, > > https://github.com/kubernetes-sigs/controller-tools/blob/main/pkg/crd/schema.go#L277 > > changing this line to > > ``` > typeInfo := typeInfoRaw.(interface{ Obj() *types.TypeName }) > ``` > > fixes it...