tetragon icon indicating copy to clipboard operation
tetragon copied to clipboard
verified publisher icon cilium

fix(deps): update module github.com/prometheus/client_golang to v1.20.2 (main)

Open cilium-renovate[bot] opened this issue 1 year ago • 1 comments

This PR contains the following updates:

Package Type Update Change
github.com/prometheus/client_golang require minor v1.19.1 -> v1.20.2

Release Notes

prometheus/client_golang (github.com/prometheus/client_golang)

v1.20.2

Compare Source

  • [BUGFIX] promhttp: Unset Content-Encoding header when data is uncompressed. #​1596

v1.20.1

Compare Source

This release contains the critical fix for the issue. Thanks to @​geberl, @​CubicrootXYZ, @​zetaab and @​timofurrer for helping us with the investigation!

  • [BUGFIX] process-collector: Fixed unregistered descriptor error when using process collector with PedanticRegistry on Linux machines. #​1587

v1.20.0

Compare Source

Thanks everyone for contributions!

:warning: In this release we remove one (broken anyway, given Go runtime changes) metric and add three new (representing GOGC, GOMEMLIMIT and GOMAXPROCS flags) to the default collectors.NewGoCollector() collector. Given its popular usage, expect your binary to expose two additional metric.

Changes

  • [CHANGE] :warning: go-collector: Remove go_memstat_lookups_total metric which was always 0; Go runtime stopped sharing pointer lookup statistics. #​1577
  • [FEATURE] :warning: go-collector: Add 3 default metrics: go_gc_gogc_percent, go_gc_gomemlimit_bytes and go_sched_gomaxprocs_threads as those are recommended by the Go team. #​1559
  • [FEATURE] go-collector: Add more information to all metrics' HELP e.g. the exact runtime/metrics sourcing each metric (if relevant). #​1568 #​1578
  • [FEATURE] testutil: Add CollectAndFormat method. #​1503
  • [FEATURE] histograms: Add support for exemplars in native histograms. #​1471
  • [FEATURE] promhttp: Add experimental support for zstd on scrape, controlled by the request Accept-Encoding header. #​1496
  • [FEATURE] api/v1: Add WithLimit parameter to all API methods that supports it. #​1544
  • [FEATURE] prometheus: Add support for created timestamps in constant histograms and constant summaries. #​1537
  • [FEATURE] process-collectors: Add network usage metrics: process_network_receive_bytes_total and process_network_transmit_bytes_total. #​1555
  • [FEATURE] promlint: Add duplicated metric lint rule. #​1472
  • [BUGFIX] promlint: Relax metric type in name linter rule. #​1455
  • [BUGFIX] promhttp: Make sure server instrumentation wrapping supports new and future extra responseWriter methods. #​1480
  • [BUGFIX] testutil: Functions using compareMetricFamilies are now failing if filtered metricNames are not in the input. #​1424
All commits

New Contributors

Full Changelog: https://github.com/prometheus/client_golang/compare/v1.19.1...v1.20.0

Configuration

📅 Schedule: Branch creation - "on monday and friday" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

  • [ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

cilium-renovate[bot] avatar Aug 16 '24 11:08 cilium-renovate[bot]

ℹ Artifact update notice

File name: go.mod

In order to perform the update(s) described in the table above, Renovate ran the go get command, which resulted in the following additional change(s):

  • 1 additional dependency was updated

Details:

Package Change
github.com/prometheus/common v0.48.0 -> v0.55.0

cilium-renovate[bot] avatar Aug 28 '24 15:08 cilium-renovate[bot]

Deploy Preview for tetragon ready!

Name Link
Latest commit a24e43302bddc7e98836158bdbaa22dbb0194e19
Latest deploy log https://app.netlify.com/sites/tetragon/deploys/66d7fd8a4ca505000892a3b9
Deploy Preview https://deploy-preview-2815--tetragon.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Sep 04 '24 06:09 netlify[bot]

Most of the errors are connection errors, except for this:

=======================================================================================


 ██████╗ ████████╗███████╗██╗         ██████╗ ███████╗███╗   ███╗ ██████╗
██╔═══██╗╚══██╔══╝██╔════╝██║         ██╔══██╗██╔════╝████╗ ████║██╔═══██╗
██║   ██║   ██║   █████╗  ██║         ██║  ██║█████╗  ██╔████╔██║██║   ██║
██║   ██║   ██║   ██╔══╝  ██║         ██║  ██║██╔══╝  ██║╚██╔╝██║██║   ██║
╚██████╔╝   ██║   ███████╗███████╗    ██████╔╝███████╗██║ ╚═╝ ██║╚██████╔╝
 ╚═════╝    ╚═╝   ╚══════╝╚══════╝    ╚═════╝ ╚══════╝╚═╝     ╚═╝ ╚═════╝


- All services are available via the Frontend proxy: http://localhost:8080
  by running these commands:
     kubectl --namespace labels port-forward svc/otel-demo-frontendproxy 8080:8080

  The following services are available at these paths once the proxy is exposed:
  Webstore             http://localhost:8080/
  Grafana              http://localhost:8080/grafana/
  Load Generator UI    http://localhost:8080/loadgen/
  Jaeger UI            http://localhost:8080/jaeger/ui/
--- FAIL: TestLabelsDemoApp (118.64s)
    --- FAIL: TestLabelsDemoApp/Run_Event_Checks (80.14s)
        --- FAIL: TestLabelsDemoApp/Run_Event_Checks/Run_Event_Checks (80.14s)
            rpcchecker.go:171: 
                	Error Trace:	/home/runner/actions-runner/_work/tetragon/tetragon/go/src/github.com/cilium/tetragon/tests/e2e/checker/rpcchecker.go:171
                	            				/home/runner/actions-runner/_work/tetragon/tetragon/go/src/github.com/cilium/tetragon/vendor/sigs.k8s.io/e2e-framework/pkg/env/env.go:422
                	            				/home/runner/actions-runner/_work/tetragon/tetragon/go/src/github.com/cilium/tetragon/vendor/sigs.k8s.io/e2e-framework/pkg/env/env.go:453
                	Error:      	Received unexpected error:
                	            	event checker labelsEventChecker failed to receive event: rpc error: code = Internal desc = grpc: error while marshaling: marshaling tetragon.GetEventsResponse: size mismatch (see https://github.com/golang/protobuf/issues/1609): calculated=321, measured=829
                	Test:       	TestLabelsDemoApp/Run_Event_Checks/Run_Event_Checks
                	Messages:   	checks should pass
FAIL
coverage: [no statements]
I0904 06:41:34.330191   17923 dumpinfo.go:48] "Dumping test data" dir="/tmp/tetragon.e2e.TestLabelsDemoApp.1245090608"

Based on the discussion in https://github.com/golang/protobuf/issues/1609, it seems that the error might be coming from changes in the object sent in the gRPC. I believe we had issues with this in the past, but it seems unrelated to this PR. My suggestion would be to merge the PR and crate a kind/ci-flake for the above error. @mtardy thoughts?

kkourt avatar Sep 04 '24 07:09 kkourt

Based on the discussion in https://github.com/golang/protobuf/issues/1609, it seems that the error might be coming from changes in the object sent in the gRPC. I believe we had issues with this in the past, but it seems unrelated to this PR. My suggestion would be to merge the PR and crate a kind/ci-flake for the above error. @mtardy thoughts?

Yeah agree, I think William may have already investigated a gRPC size mismatch error and might be able to help us understand but this is something we see from time to time.

I'll rerun some of the tests as some real infra flakes happened for them.

mtardy avatar Sep 04 '24 09:09 mtardy

CI issue: https://github.com/cilium/tetragon/issues/2875

kkourt avatar Sep 04 '24 11:09 kkourt