Michael Tietz
Michael Tietz
> @mt-software-de I think stock_helper is not a good idea module at the beginning as you can put everything in it and having no idea what it does really. It's...
Ping @rousseldenis @simahawk @jbaudoux
FYI: @jbaudoux
@pedrobaeza and @chienandalu i will redo the PR https://github.com/OCA/rma/pull/334 Using this PR as an starting point.
@pedrobaeza and @chienandalu could you please review this PR?
> @mt-software-de Can you drop the changes to generated files? Done. What can we do with this one? @pedrobaeza all of your change request are solved.
stock_helper is in fact not needed, but `delivery_procurement_group_carrier` is needed. Otherwise it is not possible to set the carrier via the proc group. Please check the change in [rma_delivery/models/rma.py](https://github.com/OCA/rma/pull/350/files#diff-1f0be814effba842b213ac1e77b08a9ff3572e62096674780e9d66ed04aac04c)
> > A good answer would explain why > > It's not the first time I have asked you about this. And you ask us about doing glue modules for...
> Finally merged in v16 #392 with some changes (e.g. Change `reception_move_ids` to `reception_move_id`), I think PR should be adapted to the same changes. Thats good, that there is now...
> I am trying to clarify everything a bit. > > This was left pending from [#350 (review)](https://github.com/OCA/rma/pull/350#pullrequestreview-2014555447) until now (otherwise this would have been taken to later versions and...