Marc Suñé

Results 53 comments of Marc Suñé

>And it is superseded by the fact that hard coded assertions cannot have an exhaustive coverage. Why do you think so? The fact that the output is synthetically generated (and...

Thanks. The only piece of information that yo @rodonile added to the conversation is that Paolo was aware of that. That's ok. Just to be clear, my concerns, in order...

> Hi @joestringer @gentoo-root,Please review. @haozhangami @gentoo-root will be OOO until Fri/next. Can we assign another reviewer?

> In the end I decided to use an external implementation (wireshark) to validate my checksums and to hardcode a known good value. > > But I am open to...

Both IPv4 and ICMP checksums are incorrect. ``` 07:40:28.611541 IP (tos 0x0, ttl 64, id 40427, offset 0, flags [DF], proto ICMP (1), length 84, bad cksum 4892 (->8792)!) 10.96.0.10...

@mikn I would suggest to split this PR in two: > A) Drop Traffic to Non-existent Service Ports: Traffic destined to virtual service IPs on ports where no service is...

This comes from #4810. I've revised a number of fields. A couple of thoughts: * I **didn't test** the changes, I am just opening this Draft PR for discussion. *...

> we likely should try to adapt the code so that it supports NBytesField to support integer values of arbitrary lengths. Right now this code likely won't work. Ack. It...

> It is strange you don't get anything, you should get a warning about the condition in the log, see here: You are right. I seem to have missed _the...

Draft PR for discussion. Still not integrated with the CI