Mihail Stoykov

Results 127 comments of Mihail Stoykov

As I mention in https://github.com/grafana/xk6-browser/pull/574#discussion_r992035380 we can use the k6's https://github.com/grafana/k6/blob/fcbbcd54acb2ee58cf16d6a15c730809a541afe9/lib/types/types.go#L190-L211 but it will add support for "1s" , "5m" which is something playwright doesn't support. Argaubly that is better...

@inancgumus the k6 one already supports integers(and floats) and interpret them as milliseconds, which seems to be the de facto standard across the js world :shrug:

I also prefer to have issues per flaky test (or behaviour) as that way it could be discussed per case what hte solution can be

@BRK0014 I think I tried, bu I no longer work for the company I was at the time, so it will be hard to check :(. And I remember my...

@nwidger , currently one of the big questions is whether we can fix the `print` and `exec` to work in a useful manner. That definitely depends on @dop251 being happy...

> As for resolving variables, I think there is an easier approach: variable names are kept at runtime when (and only when) there is a possibility of a dynamic lookup...

Current problems from [my "integration" with k6](https://github.com/k6io/k6/tree/feature/PoCDebugger): 1. next/stepin either don't work very well or not at all. They sometimes just don't do anything and then they jump ... or...

> @mostafa @MStoykov Would it make sense to enable debugging with something like an optional `WithDebugMode` option to `Compile`/`CompileAST`/`MustCompile` instead of adding a whole new `CompileASTDebug` function? This would be...

Sorry for the slow reply @faisalraja , there has been some holidays ;). The API is far from complete (everything really is) - but no. In order for the possibility...

A [draft PR](https://github.com/dop251/goja/pull/430) has been opened :tada: