Markus Stange
Markus Stange
Looks pretty nice! But I think we should add more ways to exit this view. I can think of these three ways that users might try to get back out...
@flodolo I believe the changes you requested have been applied, could you approve?
Once we remove the active tab view (#4997), we can just remove this column entirely, see #5443.
JavaScript cannot represent this integer. ``` > (0xFFFF_FFFF_FFFF_FFFF).toString(16) "10000000000000000" ```
Ah yes, a BigInt would work. But then we also have to fix ChromeUtils.setPerfStatsCollectionMask on the Firefox side to accept BigInts.
I don't know the answer, this is a question for our DOM team
I am no longer able to load a .trace file (/ directory) in the deploy preview using Firefox Nightly. Is this a Firefox Nightly bug? When I try to choose...
Whoa, I just found some actual documentation! It's packaged inside Instruments.app: file:///Applications/Xcode.app/Contents/Applications/Instruments.app/Contents/Packages/Sampling.instrdst/Contents/Documentation/fulldoc.html If you view a profile in Instruments, you can access this documentation by going to: Main Menu ->...
I have a bug report: Inlined frames seem to be assigned to the wrong parent. It seems they're lifted up one level and become a *sibling* of their actual parent....
This implementation also seems to create huge frameTables / funcTables / stringTables. It seems every thread has all the strings for all the threads. And the frameTable.address values seem wrong.