Martin Solli

Results 16 comments of Martin Solli

Thanks, good that you could reproduce locally. It was driving me crazy. Anyway, I was wondering about the number 46, which seemed overly arbitrary to me. Then I had a...

Hi @areina! I might be inclined to something with OpenTelemetry, but so far I've covered my use cases by wrapping the `enqueue!` and `handler-fn!` functions. Do you have any thoughts...

How so? Jobs are written and queried using Java `Instant`s, which are oblivious of timezones. Have you observed confusing behavior, and in what way?

Thanks for the detailed analysis! It really is more complicated than I first thought, precisely because of the `Timestamp/toString` method you mention. Or rather, it's the `org.postgresql.jdbc.TimestampUtils/toString` method that is...

Thanks for reporting! Both these have now been fixed: https://github.com/msolli/proletarian/commit/b991f66d85c4ba63c278d8da630c344752ca787d https://github.com/msolli/proletarian/commit/2ee188f3ffb1d96cbd5776ae184dce79d5d73b26 To use the latest Proletarian with these fixes: ``` msolli/proletarian {:git/url "https://github.com/msolli/proletarian" :sha "2ee188f3ffb1d96cbd5776ae184dce79d5d73b26"} ```

The reason why Proletarian does not catch `Throwable` is because then we would also catch errors that are subclasses of `java.lang.Error`, which include serious and critical conditions in the JVM...

I can see three approaches for how to handle `AssertionError`: 1. Catch and ignore (and log it). Continue working on jobs. 2. Catch and retry - the same semantics as...

OK, so we agree that `AssertionError` should make the job fail, and that this is caused by an application bug that must be fixed before the job can be retried....

Hi, and thanks for your interest in Proletarian! I've gone back and forth in my mind about exposing job-id to the job handling function. In the end I've decided that...

I think in the end I don't want to prematurely commit to a signature for the handler-fn that has too much information in it. I haven't seen any use for...