Michele Sardo

Hello, have you tried using `VISAAdapter`, since you are using the device via LAN, you should supply an address like this: `TCPIP::` (see also https://pyvisa.readthedocs.io/en/latest/introduction/names.html), that is: `generator = Agilent33500("TCPIP::")`....

@bmoneke, I am sorry I am not able to follow the discussion as I am on holiday in these days, but I think the binary version of the read and...

> > @bmoneke, please find a first set of comments for the adapter file. > > Thanks for your comments. I'm on vacation, so I'll respond later. Enjoy :)

> In my opinion, this could be a good approach. For sure pyvisa people knows a lot more regarding instruments interface :).

> Regarding read/write_binary_values I face a difficult choice: Pyvisa's methods require knowledge of the term_chars. Here are some options how to implement it, what do you think is best? >...

> @bmoneke thanks for the clarification. I would propose to implement the `read_binary_values/write_binary_values` into root class `Adapter` with similar implementation of what is currently available in `SerialAdapter`, this will limit...

Il Mer 31 Ago 2022, 18:42 Benedikt Moneke ***@***.***> ha scritto: > @bmoneke thanks for the clarification. I > would propose to implement the read_binary_values/write_binary_values > into root class Adapter...

I have checked quickly and apparently the problem is in the line `cls(adapter=MagicMock())`. The class `HPLegacyInstrument` requires also `name` parameter and so the test fails. I am not sure which...

I think this PR could address several cases similar to this. I recently had same problem with Anritsu MS2668C. I also think that same problem could happen for other commands...

> * the methods don't contain any logic and can be implemented in a subclass without much code duplication I think this make sense and also the comment of @bilderbuchi...