Marcelo Shima

Results 573 comments of Marcelo Shima

This is a `windows-release` package bug (https://github.com/sindresorhus/windows-release/issues/14). Maybe you could try: https://github.com/apache/cordova-cli/issues/434#issuecomment-491292390

Latest macos-release is esm only. Need to catch the exception at https://github.com/yeoman/insight/blob/8a3c05dd4da8b4e36fca60862bb0900dfef0aa7d/lib/index.js#L37 And fallback to unknown.

Not sure how the implementation would look like, looks complex and I don't understand the reason. But I think this will somewhat covered by https://github.com/jhipster/generator-jhipster/issues/19111.

Not sure this still applies. Moment was replaced with Dayjs.

We should convert to blueprint, like we did with ionic. We should not integrate into genetor-jhipster, blueprints are really powerful and easy now. As a module it is more difficult...

The custom implementation can support others databases and reactive. I don't think javers has reactive support. An interesting follow up is to let jhipster generate the `EntityAuditEvent`, repository and rest...

A e2e test is missing too. Add a TestAuthorityRelationship to https://github.com/jhipster/generator-jhipster/tree/master/test-integration/samples/.jhipster. And insert here: https://github.com/jhipster/generator-jhipster/blob/0e4b8dc74087603bc781ce2d9983251722af0314/test-integration/scripts/11-generate-entities.sh#L117-L118 I think this is the last round.

@xetys have you noticed the failures are related to your PR?

> still failing because oauth2 is an edge case....I see this is one of the nastiest $100 bug bounties in history :D I'll try to fix that one today >.<...