Marcelo Shima

Results 573 comments of Marcelo Shima

> Which code do you want to analyze on PRs? Generated code or the generator code itself? Generated code > Generated code means a lot of sonar invocations on each...

Migrating generators to typescript is not a goal for v8. But can be done during v8 cycle.

Profile (dev or prod) may be required. Cannot test in the moment.

See my original comment https://github.com/jhipster/generator-jhipster/pull/13717#discussion_r566744125. I’ve failed to make it cross platform already. We could try double -- . concurrently -k -s first "npm run ci:e2e:server:start" "npm run e2e:headless --...

I think I've came across cross-env and cross-var back in the time. But IMO we shouldn't use any of them, cross-env is reportedly deprecated (the original repository was archived) and...

@tautera can you add this file: https://github.com/jhipster/generator-jhipster-native/blob/main/generators/server/templates/.npmrc

@tautera try updating npm to 8.10.0. https://github.com/npm/cli/commit/e69be2ac5c35e985732e2baa00b70d39332e4b9f Actually v7.6.1.

Or running `npmw run e2e`

IMO JSONB only makes sense at jhipster as an embedded Object, like `@Embedded` works currently. https://github.com/vladmihalcea/hibernate-types#hibernate-6 using POJO.

From what I’ve seen, it’s doable and will reduce complexity due to shared dependencies between oauth2 and jwt.