Marcelo Shima

Results 573 comments of Marcelo Shima

@DanielFran all green.

We do have shared actions in https://github.com/jhipster/actions and have `jhipster github-build-matrix` command. In the issue we don't need to create new shared actions, but use those supported actions like in...

`getWebappTranslation` type needs unification. It deserves an PR only for that. See https://github.com/jhipster/generator-jhipster/pull/27289#discussion_r1761371732. I will take care of it.

There are lots o new changes since last review. - we should not try to refactor. We have `@ts-nocheck` in some files yet like https://github.com/jhipster/generator-jhipster/pull/27803 - methods should not be...

> No no, I just touched 2 lines since last review (the 'deprecated-types.ts' file, 'ensure retrocompatibility' commits), I was forced to rebase, and as older commit went in between (and...

We have PartialAngularEntity and AngularEntity now. That's bad.

In my opinion types are in 'good' shape now. When an option is added to config, the option will appear in application, in jhipsterConfig, in jhipsterConfigWithDefaults, will be parsed, will...

If this .yo-rc.json is generated by [https://start.jhipster.tech](https://start.jhipster.tech/generate-application), there is a bug there. Reactive with cache is not supported.

Why so? You must reduce the size of the window.

@xvaara I've tried to create another repro with more dropdown items to avoid windows resizing but the stackblitz sample is not working, keeps loading forever: https://bootstra-vue-next-template-sph2dqmu.stackblitz.io Edit: Nevermind it requires...