Marcelo Shima
Marcelo Shima
> you can checkout https://github.com/faker-js/playground and test your changes Why don’t integrate playground on ci tests?
@Shinigami92 I am on mobile now, so I cannot rebase. I think it’s only missing steps names now. Feel free to modify the PR. Playground is passing 🚀
Playground seems to be missing pure node ts samples.
For some reason mapping types to non existing index.d.ts fixes playground. In the end it just adds the playground workflow
IMO running playground in CI: - reduces maintenance burden by avoiding regressions and requiring manual checks: https://github.com/faker-js/faker/pull/3093#issuecomment-2339729022. - improves contribution experience by not having to ask to manually check against...
@zhangHongEn I've found the error. The exposed modules was not found. Execution `vite` correctly shows the error message, but `vite build` erroring with this error. Happened when migrating from Webpack...
> @mshima Can we add a warning in the terminal for this? Would be nice to fail with correct error message.
Liquibase changelog should be polished, you can see in ng-default sample compare: ```diff a/src/main/resources/config/liquibase/changelog/20160208210109_added_entity_constraints_TestCustomTableName.xml @@ -10,6 +10,9 @@ --> + + + + + +
I think we should keep the same blank lines to avoid unnecessary diff when upgrading applications, specially changelogs.
Updated files are not overridden. There is no problem on changing format.