Sean Gilligan

Results 492 comments of Sean Gilligan

And I should be clear, I'd be happy with migrating to Maven for the 0.18 release if someone submitted a quality PR that meets our requirements (which I defined in...

Having Gradle 9 support (for optional modules) allows us to do #3876 which is very important for our 0.19 release where we hope to have Schnorr + Taproot)

> there was circular dependency issue I believe it was fixed by PR ##3850. If not, please let us know.

I updated the description/first-comment to reflect that Debian Trixie is released and that "Franken-Gradle" 4.4 lacks built-in support for modular Java builds.

In my opinion a Maven build is a "nice-to-have" for [0.18](https://github.com/bitcoinj/bitcoinj/milestone/5), but a requirement for [0.19](https://github.com/bitcoinj/bitcoinj/milestone/7).

That sounds like a great plan. Doing it in phases allows us to give you feedback early which is also good. Did you see the (partial) list of Maven plugins...

Looks good. Please proceed with phase 2. We should probably add a GitHub `maven.yaml` workflow so we can start testing the Maven build. Do you feel comfortable doing that as...

We need to specify the minimum supported Maven version. In the Issue description above I suggested 3.9.9 -- probably because that is what is provided by Debian 13/Trixie. If necessary,...

> Yes I totally miss that. Ok let's set this as 3.9.9 as min version, I think we need some additional plugin to enforce versioning, but let me check this...

> So in my experience if something is not enforced it definitely will be used … maybe we can skip for now and add this later Do what you think...