Marc Schmitzer comments

Results 6 comments of


                                            Marc Schmitzer

http: Put exception in the queue in connection_lost

Hi, I'm afraid pr-25 doesn't quite cut it for me, it brings back the hung fibers I originally set out to fix. I think the problem is that the `_message`...

http: Put exception in the queue in connection_lost

Any updates on this? I've updated the branch with your variant of the "Put exception in queue" commit and another commit that drops the message object in `message_complete` to make...

Query time (and other actions) produce arbitrary output

I agree that trying to solve this through sanitation is messy. But I do think that `check_postgres.pl` has the responsibility to produce well-formed output here. We're not talking about the...

--env-token-name flag is defaulted to `access_token`, its not possible to set it to `none` which would activate different jinja template features

Ran into the same issue. Simply defaulting the `--env-token-name` option to `None` would be good, IMO. I can file a PR if that helps, but it seems silly for a...

consider-using-with assigning TemporaryDirectory() to class attribute

I feel like this is part of a more general problem with `consider-using-with` that would ideally be fixed by detecting that the context manager object is somehow preserved beyond the...

Bug: Migration failures with distributed ClickHouse cluster using SENTRY_DISTRIBUTED_CLICKHOUSE_TABLES

I think I've run into the same problem with a self-hosted Sentry setup and a separate Clickhouse instance. It seems the problem is caused by [a change in Clickhouse 25.4](https://github.com/ClickHouse/ClickHouse/pull/74481)....