Mathieu Scheltienne

Results 36 comments of Mathieu Scheltienne

@jasmainak I have no idea. I never used it and I don't know what it's supposed to do. I just noticed that the argument of the function is not used...

Any way you put it, the fact you are asking an argument to the user; to then throw it into the trash looks very suspicious ;)

@alexrockhill Also, the values in the description of the function and in the description of `lm_cutoff` don't seem to match. Intended? https://github.com/mne-tools/mne-python/blob/c8d8c5f72e6714ae147994effcee8efe04c648f4/mne/preprocessing/_csd.py#L198-L201 and https://github.com/mne-tools/mne-python/blob/c8d8c5f72e6714ae147994effcee8efe04c648f4/mne/preprocessing/_csd.py#L213-L217

@alexrockhill Sorry that I did not get back to you earlier on this. The function description is not clear to me and to @ArthurNguyen who reported this to me. ![image](https://user-images.githubusercontent.com/73893616/184538002-08bd86bd-26a5-42fd-b661-c7015dcb507c.png)...

I clean-up a bit the reference to remove the double-link when both URL and DOI were provided. I checked each DOI individually to make sure they were correct.

OK, then where does the value 5 come from? EEGLAB default? How about rephrasing as: ``` First, an electrical distance matrix is computed by taking the pairwise variance between electrodes....

Render: https://output.circle-artifacts.com/output/job/0fadf717-2dcd-4b69-a4a4-9b86b04d04fd/artifacts/0/dev/generated/mne.preprocessing.compute_bridged_electrodes.html?highlight=compute_bridged_electrodes#mne.preprocessing.compute_bridged_electrodes

IMO, default documented entries would bring more good than harm.

I actually never thought about this in terms of python indexing, that does help a lot! Sure there is a way to get by with the current arguments; but I...

Hello everyone, I wanted to thank you for all your reviews and apologize for the time it takes @vferat and myself to respond and address your reviews. We are lacking...