Mrunal Patel
Results
79
comments of
Mrunal Patel
I think we can drop the first commit, otherwise this looks fine.
Can you rebase to pick up ci fixes?
@tedyu can you look at this one?
@kolyshkin @saschagrunert ptal
Needs rebase
@vinayakankugoyal Thanks for the PR! What about the case where a user drops ALL and adds back the default set?
@dcbw wdyt of @giuseppe changes?
@squeed how do we get this fixed in the CNI plugins?
This seems reasonable. We should make sure that we match the logic in https://github.com/kubernetes-incubator/cri-o/blob/master/server/container_create.go#L379.