Marc Rousavy
Marc Rousavy
Hey does this still crash? I made some changes here and there. Also error reporting should be better now.
Maybe I just fixed this in https://github.com/mrousavy/react-native-vision-camera/pull/2408 - could you test and verify?
Can you try removing those 25 lines: https://github.com/mrousavy/react-native-vision-camera/blob/4e96eb77e0755edf5a4351d61fa36d60415f1db6/package/android/src/main/java/com/mrousavy/camera/core/CameraSession.kt#L436-L460 And see what happens?
@iketiunn @lc-mm thanks for testing. Can you try to add each setting back one by one to find out which of those format settings is causing the Camera to fail?...
Wait so zoom makes it break?
Gotcha, yep I'll try to fix this on the fly when I finish #2049 :)
I **think** I just fixed this in #2049, and released it to npm (v3.6.0) 🎉 Please try the latest release and let me know if this is still an issue....
@zjkuang what happens if you change this line here: https://github.com/mrousavy/react-native-vision-camera/blob/f4617a3918783ff188c8b63f0694b1ad94ce3fae/package/android/src/main/java/com/mrousavy/camera/core/CameraSession.kt#L367 to ```kt val captureSession = captureSession ?: return ``` ?
So it is a race condition I'd say
I wonder why zoom makes this break, are you passing a custom zoom value? What's going on here