Marc Rousavy
Marc Rousavy
Hey @bglgwyng - could you try to reproduce this bug again with react-native-worklets-core 0.3.0 (includes a fix) and VisionCamera from current `main` branch (includes a ton of fixes again)?
Hey - @bglgwyng did you test if this is fixed now in 3.9.x?
> The example app crashed or showed a black screen on my Galaxy S21 after upgrading to 3.9.0 Wait what? Is there an issue for this? That's weird.
Is that with `enableGpuBuffers` set to `true` or `false`?
@bglgwyng `vision::JVisionCameraScheduler::trigger()+120` is just so weird. I don't know in what case this is ever being called ๐คจ Is that immediately on camera startup or just after a while of...
or is that on some session change, like a prop to the Camera changes or you fast-refresh?
I'm still not sure what's actually broken here? Both runAtTargetFps and runAsync work for me in the example app (at least on 3.8.x, I'll double check if it works on...
> `count` in deps triggers reinitializing of the frame processor. So you think the Frame Processor being updated causes a crash?
This is the code that gets called when the Frame Processor changes: https://github.com/mrousavy/react-native-vision-camera/blob/f6b7163660679599e48d1b75ab444ba8b5564809/package/android/src/main/cpp/frameprocessor/java-bindings/JVisionCameraProxy.cpp#L59-L70
lol yes this should actually be there, I don't know why I didn't spot that mistake ๐ can you send a PR? looks good