Marc Rousavy
Marc Rousavy
Is there any case where a `set` could fail? Unless there's some critical memory error or something I feel like this is a bit unnecessary 🤔
Good point. Hm, I'll think about this and come back soon Anyways, the PR is good & well implemented, thank you so much!
Hey, thanks so much for your PR, this is really exciting. I am a bit swamped with work right now, so it might take a few days before I can...
Oh, whoops. Hmm I don't think reverting that change makes sense as that was more than a year ago and most people are already on that version by then, meaning...
MMKV Core is already working on this; https://github.com/Tencent/MMKV/commit/06797a74505043ede9b239afe244cab0d3623aa5 We don't need a privacy manifest, we will just no longer rely on those sensitive APIs.
MMKV didn't create a new release yet.
@dependabot rebase
Did you add `AppGroup` to `Info.plist`? https://github.com/mrousavy/react-native-mmkv/blob/6fa83b5f30fdbf4f91f192d62d0cef6483106177/ios/MmkvModule.mm#L49-L57
Okay so the MMKV instance gets created with AppGroups... idk
> Also wanna add trim() function. https://github.com/mrousavy/react-native-mmkv/pull/461