Marc Rousavy comments

Results 1816 comments of


                                            Marc Rousavy

fix(Android): build error

Hi thanks for your PR, unfortunately there's conflicts

Settings a `false` value is equivalent to delete

Huh? Are you sure? I think I tested that... On iOS or Android or both?

Settings a `false` value is equivalent to delete

Hmm, this is weird, maybe there is some casting going on? Can this be reproduced in the example app?

Settings a `false` value is equivalent to delete

Hey! Does this problem still persist? Is the code you posted the reproduceable example?

Fails silently when using bad path

Oh that's interesting. Is there something being printed to Xcode Logs / Android Logcat?

Fails silently when using bad path

> Still would be nice to see these bubble up to the JS log No, lol that would be pretty annoying as it spams a lot. A native library logs...

Fails silently when using bad path

Does this issue still persist?

[Android] Failed to create a new MMKV instance: React Native is not running on-device. MMKV can only be used when synchronous method invocations (JSI) are possible.

Hey! 1. Can you reproduce the issue in a fresh app that only has react-native-mmkv installed? 2. I believe this is related to react-native-reanimated.

React Native MMKV fails to build due to fbjni-0.5.0-headers.jar responding with 404

Hey! Yea the latest version of react-native-mmkv fixes this issue, make sure y'all upgrade to 2.10.1! :)

Unclear docs regarding encryption

100% agree with @francesco-clementi-92 here!