Manuel Rossard

Results 47 comments of Manuel Rossard

IMO 404 is a correct response : the server was indeed unable to find the requested resource. That being said, a simple "fix" could be to just log the ProviderNotFoundException,...

> > IMO 404 is a correct response : the server was indeed unable to find the requested resource. > > @mrossard , beh, technically, the server doesn't even know...

I do understand your point, but still think having a "userland" error for this wouldn't be ok for some use cases / could have unwanted side effects. By logging i...

just a comment to stop this from closing, trying to find the time to complete this.

At long last I found some time to revisit this PR. @soyuka what do you think ? I haven't looked at how it fits in with https://github.com/api-platform/core/pull/6801 yet, but i...

> My question is more: doesn't object mapper already does the transformation hook ? I'm not sure we need a transformation hook when using the object mapper. If you mark...

Am I missing something? I only added 3 lines to a file, what's the conflict here? :D

> @mrossard the conflict is in `use`. You need to rebase. oh, cool, i'm just dumb then. :D I was sure i had pulled the changes before creating the branch,...

I rebased it and added the logger to the api_platform.state_provider.read service definition on the symfony config side. Not sure if there's something similar to do for laravel...?

That's a very interesting proposal! I'm not sure the concept of a provider for the Author object works as is though, or at least it probably makes things work very...