core icon indicating copy to clipboard operation
core copied to clipboard

feat(dx): additional log to help locate a potential missing provider

Open mrossard opened this issue 1 year ago • 4 comments

Q A
Branch? main
Tickets Closes #6335
License MIT

Just adding a simple log to avoid completely hiding the fact that there was a ProviderNotFoundException behind a NotFoundHttpException. It could help save time for devs who simply forgot to implement the provider.

mrossard avatar Aug 18 '24 06:08 mrossard

Am I missing something? I only added 3 lines to a file, what's the conflict here? :D

mrossard avatar Aug 21 '24 13:08 mrossard

@mrossard the conflict is in use. You need to rebase.

dunglas avatar Aug 22 '24 10:08 dunglas

@mrossard the conflict is in use. You need to rebase.

oh, cool, i'm just dumb then. :D I was sure i had pulled the changes before creating the branch, sorry.

I'll try to look at how it can be added in the profiler/ web debug toolbar too, that's a great point.

mrossard avatar Aug 22 '24 11:08 mrossard

(The profiler part can be done in another PR, this one LGTM).

dunglas avatar Aug 22 '24 13:08 dunglas

I rebased it and added the logger to the api_platform.state_provider.read service definition on the symfony config side. Not sure if there's something similar to do for laravel...?

mrossard avatar Aug 30 '24 11:08 mrossard