Marshall Roch

Results 22 issues of Marshall Roch

`Super` is currently only in def/babel.js, but it's part of estree and also used by esprima.

The esprima def recognizes `ExportDeclaration`, which AFAICT was from the `harmony` branch of esprima which is abandoned, and esprima (and estree) now uses `ExportNamedDeclaration` and `ExportDefaultDeclaration`. https://github.com/jquery/esprima/pull/1149 these defs are...

I've received reports of `Unix.Unix_error(Unix.EBADF, "close", "")` exceptions that stem from this `process#close`: https://github.com/ocsigen/lwt/blob/7355895d89e11aed36d2348380029c57d3124aec/src/unix/lwt_process.cppo.ml#L350 Unfortunately I don't have a repro yet to understand what the process we're calling is doing,...

As with `Option.map` vs `Option.value_map`, it'd be useful (albeit rarely!) to have a `value_merge` function: ``` let value_merge a b ~default ~f = match a, b with | None, None...

forwarded-to-js-devs

I scripted the installation instructions from the README (super detailed, thanks!) using the [`aws` CLI](https://aws.amazon.com/cli/). just run `aws configure` first to set up your credentials, then `make` should set everything...

`env` is an "environment block": a null-terminated block of null-terminated strings. using `caml_stat_strdup_to_os` on it doesn't work, it only copies the first string. instead, we need to use an explicit...

https://github.com/ocsigen/lwt/blob/32042007d3051345bb98618e1a2a97b279800f27/src/unix/lwt_process_stubs.c#L91-L97 An "environment block" consists of a null-terminated block of null-terminated strings. Using `caml_stat_strdup_to_os` doesn't work because it only supports null-terminated strings -- it stops on the first \0 and...

See this code: https://github.com/clangd/vscode-clangd/blob/cee0726d4616d500a5989c28cbcb6a8ab08bef9f/src/clangd-context.ts#L118-L123 However, that codepath is skipped if serverCompletionRanking is disabled: https://github.com/clangd/vscode-clangd/blob/cee0726d4616d500a5989c28cbcb6a8ab08bef9f/src/clangd-context.ts#L110-L111 and it prevents setting `commitCharacters` on individual responses if you do have a valid use case...

this looks like forgotten debug logging. prints stuff like this to stdout ignoring logging settings ``` Obj of type Obj of type Obj of type Obj of type ```

no-pr-activity

`multistate` already sets the `relinquish_default` to `Unsigned(1)`. overwriting `kwargs["relinquish_default"]` in `multistate_input`, `multistate_output` and `multistate_value` prevents callers from changing it.

no-pr-activity