Martin Robinson

I'm converting this one back into a draft. I think we should simply implement the LayoutNG distribution algorithm outright to avoid the code churn.

This needs a bit more work. In quirks mode forced line breaks do not add line-height if the line is otherwise empty, but `` elements do! I think it is...

There is still going to be some special behavior though, because `` doesn't always add its line-height to the line. See how only the `` on the empty line adds...

Okay. I've modified the change to always add the strut size for preserved segment breaks, except in the case for `` which shouldn't do this when the line isn't empty....

> Possibly may be left for a follow-up, but note this differs from Gecko/Blink/WebKit: > > ``` > ax xb > ``` Oh yeah, that's an issue. I think it's...

Thanks for the review, @Loirooriol. I've made the changes you suggested.

I wonder if upgrading to a newer rust version would fix this?

Examples of runs: - A commit to main: https://github.com/mrobinson/servo/actions/runs/7927614317 - A WPT sync (only fails because the lack of a token to post the PR): https://github.com/mrobinson/servo/actions/runs/7930382648

> [this](https://github.com/mrobinson/servo/actions/runs/7930382648/job/21654575960#step:8:27) does look like real error: > > ``` > FileNotFoundError: [Errno 2] No such file or directory: '/home/runner/work/servo/servo/wpt-full-logs-linux-layout-2013/test-wpt.*.log' > ``` Thanks for pointing that out. Here's a run...

> Reports are empty now: https://github.com/servo/servo/actions/runs/7950107885/job/21702601400 due to failure in reporting: https://github.com/servo/servo/actions/runs/7950107885/job/21702596836#step:6:349 Looks like the issue is that the test runner cannot connect to the intermittent dashboard for some reason:...