servo icon indicating copy to clipboard operation
servo copied to clipboard

ci: Switch to version 4 of GitHub artifact actions

Open mrobinson opened this issue 1 year ago • 2 comments

This switches to version 4 of the GitHub artifact actions, which requires producing a single artifact per job and adding merge steps. In addition, the names of artifacts are standardized:

  • Build: <profile>-binary-<platform>
  • Full WPT results (only on failure): wpt-full-logs-<platform>-<layout>
  • Filtered WPT results (only on failure): wpt-filtered-logs-<platform>-<layout>

  • [x] ./mach build -d does not report any errors
  • [x] ./mach test-tidy does not report any errors
  • [x] These changes do not require tests because they just change the CI behavior.

mrobinson avatar Feb 15 '24 11:02 mrobinson

Examples of runs:

  • A commit to main: https://github.com/mrobinson/servo/actions/runs/7927614317
  • A WPT sync (only fails because the lack of a token to post the PR): https://github.com/mrobinson/servo/actions/runs/7930382648

mrobinson avatar Feb 16 '24 12:02 mrobinson

this does look like real error:

 FileNotFoundError: [Errno 2] No such file or directory: '/home/runner/work/servo/servo/wpt-full-logs-linux-layout-2013/test-wpt.*.log'

sagudev avatar Feb 16 '24 13:02 sagudev

this does look like real error:

 FileNotFoundError: [Errno 2] No such file or directory: '/home/runner/work/servo/servo/wpt-full-logs-linux-layout-2013/test-wpt.*.log'

Thanks for pointing that out. Here's a run with the updated version of the branch:

https://github.com/mrobinson/servo/actions/runs/7941029162/job/21683631506

mrobinson avatar Feb 17 '24 11:02 mrobinson

Reports are empty now: https://github.com/servo/servo/actions/runs/7950107885/job/21702601400 due to failure in reporting: https://github.com/servo/servo/actions/runs/7950107885/job/21702596836#step:6:349

sagudev avatar Feb 18 '24 16:02 sagudev

Reports are empty now: https://github.com/servo/servo/actions/runs/7950107885/job/21702601400 due to failure in reporting: https://github.com/servo/servo/actions/runs/7950107885/job/21702596836#step:6:349

Looks like the issue is that the test runner cannot connect to the intermittent dashboard for some reason:

https://github.com/servo/servo/actions/runs/7950107885/job/21702405700

Indeed it looks like the tracker is down: https://build.servo.org/intermittent-tracker/

mrobinson avatar Feb 18 '24 18:02 mrobinson

Thanks to @mukilan's great work, the intermittent dashboard should be active again. We're looking at how to make sure it doesn't go down again.

mrobinson avatar Feb 19 '24 18:02 mrobinson